Skip to content

Conversation

@csabattilas
Copy link

@csabattilas csabattilas commented Mar 16, 2025

Task Manager Fixes and Changes PR

This PR includes multiple commits. I will provide documentation detailing each commit's purpose, allowing you to review both the development process and the final outcome.

fixes, persistency and setting up unit test

This commit covers the following:

  • Added the initial bug fixes requested by the exercise
  • Persisted the list in the LocalStorage
  • Setup the jest testing framework.

--

refactor:

This commit has a nicer more descriptive commit message

  • reorganise components into feature and UI folders for better separation of concerns
  • implement path aliases with # prefix for cleaner imports (#ui, #components, #model, etc.)
  • structure state management with typed actions and action creators
  • implement reducer pattern with explicit action types for predictable state changes
  • create custom useTaskManager hook to encapsulate task-related logic and state

--

fix filter name

Simple bugfix for the New filter

--

add task name validation

Added validation for the form
I went for a simpler none-touch based validation. Only validates when trying to submit (add a new task).

--

add generic confirm dialog on task delete

Added 3rd party react-modal library to implement a modal in order to allow users to confirm deleting a task

--

boosting tailwind:

This commit meant to boost tailwind usage by:

  • configuring generic color
  • adding some button classes, following material style guide
  • added plugins for typography and forms
  • played around with some responsiveness

--

add unit tests

This commit adds unit tests for TaskItem component, useTaskManager custom hook and the taskReducer
Will downgrade the react-icon library because I think there are some typing incompatibilities. i did not dig up the reason due to short time to finish on the promised time. Downgrading solved the issues.

- reorganise components into feature and UI folders for better separation of concerns
- implement path aliases with # prefix for cleaner imports (#ui, #components, #model, etc.)
- structure state management with typed actions and action creators
- implement reducer pattern with explicit action types for predictable state changes
- create custom useTaskManager hook to encapsulate task-related logic and state
- generic color
- generic buttons
- using plugins for typo and forms
- some responsiveness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant